Fix ill-defined warn expectation #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-["include {:message => (match /legacy\\s+RSpec\\s+matcher/), :call_site => (include \"/home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31\")}"]
+[{:message=>
+ "#<#<Class:0x000055fcd6e44840>:0x000055fcd6e52bc0> implements a legacy RSpec matcher\nprotocol. For the current protocol you should expose the failure messages\nvia the `failure_message` and `failure_message_when_negated` methods.\n(Used from /home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31:in `block (4 levels) in <module:Matchers>')\n",
+ :type=>"legacy_matcher"}]
See rspec/rspec-support#452
|
@JonRowe Green. Do you want me to send PRs against 4-0-dev for this, rspec/rspec-core#2798, and rspec/rspec-support#452 ? Or ok to cherry-pick and push there? We're getting 4-0-dev built on CI anyway. |
|
PRs please |
JonRowe
added a commit
that referenced
this pull request
Dec 27, 2020
Fix ill-defined warn expectation
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…rspec/fix-deprecation-expectation Fix ill-defined warn expectation --- This commit was imported from rspec/rspec-expectations@acf85c1.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…rspec/fix-deprecation-expectation Fix ill-defined warn expectation --- This commit was imported from rspec/rspec-expectations@713e878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rspec/rspec-support/pull/452/checks?check_run_id=1566708254
See rspec/rspec-support#452