Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include_chain_clauses_in_custom_matcher_descriptions option #1279

Merged
merged 1 commit into from Jan 10, 2021
Merged

Remove include_chain_clauses_in_custom_matcher_descriptions option #1279

merged 1 commit into from Jan 10, 2021

Conversation

pirj
Copy link
Member

@pirj pirj commented Jan 8, 2021 •
edited

@pirj pirj self-assigned this Jan 8, 2021
@pirj pirj added this to the 4.0 milestone Jan 8, 2021
@pirj pirj mentioned this pull request Jan 8, 2021
Open
53 tasks
@pirj pirj requested review from JonRowe and benoittgt January 8, 2021 23:08
@pirj pirj force-pushed the remove-include_chain_clauses_in_custom_matcher_descriptions branch from 0d66479 to 0d5dedc Compare January 8, 2021 23:10
@pirj pirj added the rspec 4 label Jan 8, 2021
JonRowe
JonRowe approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, just needs a passing build

spec/spec_helper.rb Outdated Show resolved Hide resolved
@pirj pirj force-pushed the remove-include_chain_clauses_in_custom_matcher_descriptions branch from 0d5dedc to 3de30de Compare January 10, 2021 14:00
@pirj pirj force-pushed the remove-include_chain_clauses_in_custom_matcher_descriptions branch from 3de30de to 2436d5e Compare January 10, 2021 14:02
@pirj pirj merged commit d6de96f into 4-0-dev Jan 10, 2021
@pirj pirj deleted the remove-include_chain_clauses_in_custom_matcher_descriptions branch January 10, 2021 14:42
@benoittgt benoittgt mentioned this pull request Jun 1, 2021
Open
@pirj pirj mentioned this pull request Jul 18, 2021
Open
9 tasks
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
@pirj
[expectations] Merge pull request rspec/rspec-expectations#1279 from …
177f757 
…rspec/remove-include_chain_clauses_in_custom_matcher_descriptions

Remove `include_chain_clauses_in_custom_matcher_descriptions` option

---
This commit was imported from rspec/rspec-expectations@d6de96f.
@pirj pirj mentioned this pull request Jul 11, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonRowe JonRowe JonRowe approved these changes

@benoittgt benoittgt Awaiting requested review from benoittgt

Assignees

@pirj pirj

Labels
rspec 4
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pirj @JonRowe