fix for safe_sort for ruby 1.9.2 because Kernel now defines <=> for Object #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
details: as a result, safe_sort isn't anymore, and trying to =~ any objects that don't define a better <=> throws an exception. i'll attach a somewhat plausible patch momentarily |
|
Can you add a spec for this that fails in 1.9.2 without this change? |
|
Actually, looks like #81 provides them :) |
|
Brilliant. I'll check and see if anywhere else is checking for <=> while I'm at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a corresponding issue with more details about the bug.