Allow assertion that Array#reverse is not called (#1533)

* Allow assertion that Array#reverse is not called
rspec · Mar 10, 2023 · 556456c · 556456c
1 parent fa3c139
commit 556456c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rspec/mocks/space.rb b/lib/rspec/mocks/space.rb
@@ -77,9 +77,9 @@ def verify_all
 
       def reset_all
         proxies.each_value { |proxy| proxy.reset }
-        @constant_mutators.reverse.each { |mut| mut.idempotently_reset }
         any_instance_recorders.each_value { |recorder| recorder.stop_all_observation! }
         any_instance_recorders.clear
+        @constant_mutators.reverse.each { |mut| mut.idempotently_reset }
       end
 
       def register_constant_mutator(mutator)

diff --git a/spec/rspec/mocks/space_spec.rb b/spec/rspec/mocks/space_spec.rb
@@ -57,6 +57,12 @@ def define_singleton_method_on_recorder_for(klass, name, &block)
 
         expect(resets).to match_array([:dbl_1, :dbl_2])
       end
+
+      it "allows Array#reverse to be stubbed" do
+        # This is a regression check solved in rspec/rspec-mocks#1533 previously
+        # this was not possible without a change to the implementation
+        expect_any_instance_of(Array).to_not receive(:reverse)
+      end
     end
 
     describe "#proxies_of(klass)" do