Pin child-process on older J Ruby #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
fix-jruby
branch
3 times, most recently
from
6b100d7
to
0b4372a
Compare
benoittgt
approved these changes
Feb 2, 2019
benoittgt
reviewed
Feb 3, 2019
| # allow gems to be installed on older rubies and/or windows | ||
| if RUBY_VERSION < '2.2.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/) | ||
| gem 'ffi', '< 1.10' | ||
| elsif RUBY_VERSION < '2.0.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/) |
There was a problem hiding this comment.
Sorry I was thinking about this @JonRowe but shouldn't we start with the smaller version first?
if RUBY_VERSION < '2.0.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/)
# ....
elsif RUBY_VERSION < '2.2.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/)
# ....
elsif RUBY_VERSION < '1.9'
# ....There was a problem hiding this comment.
Good point, seems like it wasn't needed though due to the builds passing? Want to remove the redundant part?
benoittgt
pushed a commit
to benoittgt/rspec-mocks
that referenced
this pull request
May 18, 2019
JonRowe
added a commit
that referenced
this pull request
Jun 13, 2019
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This commit was imported from rspec/rspec-mocks@79b0708.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This commit was imported from rspec/rspec-mocks@fdc2280.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.