Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup argument forwarding on ruby-3.2 #1502

Closed
wants to merge 1 commit into from
Closed

Fixup argument forwarding on ruby-3.2 #1502

wants to merge 1 commit into from

Conversation

ojab
Copy link
Contributor

@ojab ojab commented Nov 18, 2022 •
edited by pirj
Loading

Fixes #1495
close #1497

Depends on rspec/rspec-support#553

@ojab ojab mentioned this pull request Nov 18, 2022
Closed
@pirj pirj marked this pull request as ready for review November 19, 2022 08:15
@pirj
Copy link
Member

pirj commented Nov 19, 2022

Would you throw in some examples, @ojab? You could probably reuse ones from #1497

@JonRowe
Copy link
Member

JonRowe commented Nov 19, 2022

Some specs would be good 👍

@kevindew kevindew mentioned this pull request Dec 28, 2022
Merged
@schinery schinery mentioned this pull request Dec 31, 2022
Closed
benoittgt added a commit that referenced this pull request Jan 3, 2023
@benoittgt
Fix args forwarding on Ruby 3.2
00c1ef3 
Related:
  - #1497
  - #1502
@pirj pirj mentioned this pull request Jan 3, 2023
Merged
pirj pushed a commit that referenced this pull request Jan 4, 2023
@benoittgt @ojab @pirj
Fix args forwarding on Ruby 3.2
72be544 
Related:
  - #1497
  - #1502

Co-authored-by: Slava Kardakov <ojab@ojab.ru>
pirj pushed a commit that referenced this pull request Jan 4, 2023
@benoittgt @ojab @pirj
Fix args forwarding on Ruby 3.2
449ccdb 
Related:
  - #1497
  - #1502

Co-authored-by: Slava Kardakov <ojab@ojab.ru>
pirj pushed a commit that referenced this pull request Jan 4, 2023
@benoittgt @ojab @pirj
Fix args forwarding on Ruby 3.2
0456726 
Related:
  - #1497
  - #1502

Co-authored-by: Slava Kardakov <ojab@ojab.ru>
@pirj pirj closed this in #1514 Jan 4, 2023
pirj pushed a commit that referenced this pull request Jan 4, 2023
@benoittgt @ojab @pirj
Fix args forwarding on Ruby 3.2
68fefd1 
Related:
  - #1497
  - #1502

Co-authored-by: Slava Kardakov <ojab@ojab.ru>
JonRowe pushed a commit that referenced this pull request Jan 7, 2023
@benoittgt @ojab @JonRowe
Fix args forwarding on Ruby 3.2
e0eb625 
Related:
  - #1497
  - #1502

Co-authored-by: Slava Kardakov <ojab@ojab.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confused over instance doubles, keyword args, with, and Ruby 3.2 previews
3 participants
@ojab @pirj @JonRowe