Don't convert keywords to hash in #send for verifying doubles on Ruby 3 #1520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current re-implementation of
send
on verifying doubles uses*args
by itself. Everything works fine onmain
for Ruby 2 or lower, but on Ruby 3 this converts keyword arguments to a Hash element inside theargs
array, which then gets passed to__send__
and thensuper
and (correctly) causes a failure when the method gets a Hash instead of keywords.Without this patch, the new test passes on Ruby 2.7.6 and fails on Ruby 3.1.2:
With this patch, all tests pass on all Ruby versions.
Fixes #1485