Prevent collisions on let :name and :method_name in rspec-rails examples

Fix: #2451
rspec · Feb 19, 2021 · 4aa5e0b · 4aa5e0b
1 parent 8edb660
commit 4aa5e0b
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/rspec/rails/fixture_support.rb b/lib/rspec/rails/fixture_support.rb
@@ -9,11 +9,11 @@ module FixtureSupport
         include RSpec::Rails::MinitestAssertionAdapter
         include ActiveRecord::TestFixtures
 
-        if ::Rails.version.to_f >= 6.1
-          # @private return the example name for TestFixtures
-          def name
-            @example
-          end
+        # @private prevent ActiveSupport::TestFixtures to start a DB transaction.
+        # Monkey patched to avoid collisions with 'let(:name)' in Rails 6.1 and after
+        # and let(:method_name) before Rails 6.1.
+        def run_in_transaction?
+          use_transactional_tests && !self.class.uses_transaction?(@example)
         end
 
         included do