Don't require active_record and action_controller

[bdimcheff]

My rails app doesn't use activerecord at all, so I disabled it in my environment. I noticed that rspec/rails requires active_record (and action_controller) in rspec/rails/matchers.rb anyways, even if they're disabled. I pulled those requires out and moved them into spec_helper since they're needed for the rspec specs to run. It looks like you're just ignoring the LoadErrors anyways if they aren't in the load path, so it doesn't seem to me that removing them should be a problem. The specs pass and it works fine in my app.

bdimcheff/rspec-rails@49293d5

• Brandon

[markiz]

My random guess is that AR and AC should be required before rspec/rails if they're used.

[bdimcheff]

Yeah in my spec_helper, the Rails environment is loaded before rspec/rails, and I have to imagine it's that way for everybody else, too. I'm not sure why rspec would ever need to require activerecord or actioncontroller.

[dchelimsky]

Don't require the things that are already required by Rails.

Closed by 471d6d8.