Provide deprecation message to external users of escaped_path #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def c._escaped_path(parts, internal = true) | ||
| unless internal | ||
| RSpec.deprecate("RSpec::Configuration#escaped_path", :replacement => nil) | ||
| end |
There was a problem hiding this comment.
This isn't exactly true. escaped_path needs to be moved out of example_group to the top level if they choose to use it.
There was a problem hiding this comment.
It's defined on their instance of RSpec::Configuration and it's gone in 3.0.0 hence it's deprecated...
There was a problem hiding this comment.
Oh wow, I totally mis-read things. Yep, carry on. LGTM.
|
@JonRowe thanks for tackling this! Looks good, just one small adjustment. |
[skip ci]
JonRowe
added a commit
that referenced
this pull request
Aug 4, 2014
Provide deprecation message to external users of escaped_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a deprecation for
#escaped_pathin2.99we assumed noone was using the private(ish) API but we were wrong, fixes #1127.