Fix #1865 by memoizing generated method name. #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here is that rails calls `#method_name` on the example a number of times in order to correctly generate the screenshot and then manipulate it. Given that we were randomising the integer that was generated on every call, this didn't work. This patch solves the problem by memoizing the generated method name so that the screenshot path is generated once per example and then correctly accessed on subsequent method calls.
11factory
pushed a commit
to 11factory/rspec-rails
that referenced
this pull request
Oct 18, 2017
The problem here is that rails calls `#method_name` on the example a number of times in order to correctly generate the screenshot and then manipulate it. Given that we were randomising the integer that was generated on every call, this didn't work. This patch solves the problem by memoizing the generated method name so that the screenshot path is generated once per example and then correctly accessed on subsequent method calls.
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
The problem here is that rails calls `#method_name` on the example a number of times in order to correctly generate the screenshot and then manipulate it. Given that we were randomising the integer that was generated on every call, this didn't work. This patch solves the problem by memoizing the generated method name so that the screenshot path is generated once per example and then correctly accessed on subsequent method calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that rails calls
#method_nameon the example anumber of times in order to correctly generate the screenshot and then
manipulate it. Given that we were randomising the integer that was
generated on every call, this didn't work.
This patch solves the problem by memoizing the generated method name so
that the screenshot path is generated once per example and then
correctly accessed on subsequent method calls.