Move MRI build to Github Actions #2404

benoittgt · 2020-11-18T22:54:37Z

JRuby not moved yet because there is too many issues with it at the moment.

To do in another PR?

fix ruby 3
fix flaky test with "mountable_engine?" error
~~add JRuby~~

jruby not moved because there is too many issues with it at the moment. Next step fix : - fix ruby 3 - fix flacky test with "mountable_engine?" error - add JRuby

pirj

Wonderful! Thanks!

PS mountable_engine? strikes back. Unrelated, it was the case for long.

benoittgt · 2020-11-21T00:19:16Z

Ok. For the flaky test. I nearly find it.

If you have this

# spec/generators/rspec/scaffold/scaffold_generator_spec.rb
# Generators are not automatically loaded by Rails
require 'generators/rspec/scaffold/scaffold_generator'
require 'support/generators'

RSpec.describe Rspec::Generators::ScaffoldGenerator, type: :generator do
  setup_default_destination

  describe 'standard request specs' do
    subject { file('spec/requests/posts_spec.rb') }

    describe 'with --no-request_specs' do
      before { run_generator %w[posts --no-request_specs] }
      it { is_expected.not_to exist }
    end

    describe 'in an engine' do
      before do
        allow_any_instance_of(::Rails::Generators::NamedBase).to receive(:mountable_engine?).and_return(true)
        run_generator %w[posts --request_specs]
      end

      it do
        is_expected.to contain('Engine.routes.url_helpers')
      end
    end
  end
end

bundle exec rspec spec/generators/rspec/scaffold/scaffold_generator_spec.rb --seed 58348, the stub have to be run first.

It seems the stub is leaking to other test. We are not able to reset properly to the right state after the engine test pass.

It's very late here. So maybe tomorrow I will try to keep digging, but if you have an idea... Maybe it is related to ammeter?

spec/generators/rspec/scaffold/scaffold_generator_spec.rb

.github/workflows/ci.yml

.travis.yml

pirj · 2020-11-21T15:01:47Z

spec/generators/rspec/scaffold/scaffold_generator_spec.rb

-        allow_any_instance_of(::Rails::Generators::NamedBase).to receive(:mountable_engine?).and_return(true)
-        run_generator %w[posts --request_specs]
+      it 'generates files with Engine url_helpers' do
+        in_sub_process do


👏

Wondering why it was wiping out the original method along the way.

I don't know 🤔

I suspect, and this is just a theory on my part, because when it stubs the method doesn't exist, it's then loaded, and the then stub blows it away as it was never there originally.

🤯 😱
Reminds me of #2394 (comment)

Error was + 1) InboxMailbox route email to properly mailbox + Failure/Error: + expect(InboxMailbox) + .to receive_inbound_email(to: "replies@example.com") + + ArgumentError: + wrong number of arguments (given 1, expected 0) + # /home/runner/work/rspec-rails/bundle/ruby/3.0.0/gems/actionmailbox-6.0.3.4/lib/action_mailbox/test_helper.rb:16:in `create_inbound_email_from_mail' + # ./spec/mailboxes/inbox_mailbox_spec.rb:6:in `block (2 levels) in <top (required)>' It should be fixed with Rails 6.1 rails/rails#35904

.github/workflows/ci.yml

Co-authored-by: Jon Rowe <hello@jonrowe.co.uk>

.github/workflows/ci.yml

JonRowe · 2020-11-22T11:48:03Z

.github/workflows/ci.yml

@@ -89,5 +89,6 @@ jobs:
        with:
          ruby-version: ${{ matrix.ruby }}
      - run: script/clone_all_rspec_repos
+      - run: bundle


I had to restore the script to update bundler to get the main builds working 🤔 😬

Error was happening on Ruby3.0.0-preview1

benoittgt · 2020-11-22T14:28:59Z

.github/workflows/ci.yml

+           env:
+             RAILS_VERSION: '~> 5.0.0'
+    env: ${{ matrix.env }}
+    continue-on-error: ${{ matrix.allow_failure || false }}


I doesn't seem to work. :/
https://github.com/rspec/rspec-rails/runs/1438441078?check_suite_focus=true

I am in favor of moving it to script/run_build step.

SyntaxError: /home/runner/work/rspec-rails/bundle/ruby/2.2.0/gems/actionpack-5.2.4.4/lib/action_dispatch/request/session.rb:96: syntax error, unexpected '.' id&.public_id

That build is failing genuinely.

I think they introduced a 2.2.x bug for 5.2... &. is 2.3 and above.

We have this in 3-9-maintenance 6a8fd07#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485R58

Oh, sorry, I've missed 2.2.2 is tested against 5-2-stable already.

I think they introduced a 2.2.x bug for 5.2... &. is 2.3 and above.

Yes completely and I didn't see a patch to change that ATM.

benoittgt · 2020-11-22T16:42:58Z

I think the PR can be merged. I will have extra work for 6.1.0rc1 that I will probably do in #2400

I will try to move JRuby over GA in another PR.

pirj · 2020-11-23T10:05:06Z

🎉

benoittgt · 2020-11-23T11:40:12Z

Yeehaa

Move MRI build to Github Actions

benoittgt force-pushed the move-to-github-actions branch 3 times, most recently from e6bfef7 to e64e5af Compare November 18, 2020 23:18

Move MRI build to Github Actions

fb018f1

jruby not moved because there is too many issues with it at the moment. Next step fix : - fix ruby 3 - fix flacky test with "mountable_engine?" error - add JRuby

benoittgt force-pushed the move-to-github-actions branch from 8f47c5e to fb018f1 Compare November 18, 2020 23:18

pirj approved these changes Nov 19, 2020

View reviewed changes

JonRowe reviewed Nov 21, 2020

View reviewed changes

spec/generators/rspec/scaffold/scaffold_generator_spec.rb Outdated Show resolved Hide resolved

benoittgt force-pushed the move-to-github-actions branch from 5d2c5ed to de824c2 Compare November 21, 2020 14:48

benoittgt commented Nov 21, 2020

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

benoittgt commented Nov 21, 2020

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

Avoid 'mountable_engine?' stub to leak to next specs in the same file

1d12c96

benoittgt force-pushed the move-to-github-actions branch from de824c2 to 1d12c96 Compare November 21, 2020 14:57

pirj reviewed Nov 21, 2020

View reviewed changes

.travis.yml Show resolved Hide resolved

pirj reviewed Nov 21, 2020

View reviewed changes

benoittgt added 3 commits November 21, 2020 16:04

Run the same branch on GA and Travis

6b7eec0

Share env variables to other steps with RSpec scripts

08bdd11

JonRowe reviewed Nov 21, 2020

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

Reduce dup by moving env and continue-on-error before steps

e265a35

Co-authored-by: Jon Rowe <hello@jonrowe.co.uk>

benoittgt force-pushed the move-to-github-actions branch from 06cb2ce to e265a35 Compare November 22, 2020 11:33

JonRowe reviewed Nov 22, 2020

View reviewed changes

Revert to previous working commands to install dependencies

6394472

benoittgt force-pushed the move-to-github-actions branch from cd75d59 to 6394472 Compare November 22, 2020 13:07

Set explicit hash as last arg to avoid "wrong number of arguments" error

67a9899

Error was happening on Ruby3.0.0-preview1

benoittgt force-pushed the move-to-github-actions branch from 8fb1d5c to 67a9899 Compare November 22, 2020 14:19

benoittgt commented Nov 22, 2020

View reviewed changes

continue-on-error seems to work only when defined in step

029416b

JonRowe merged commit 9217638 into main Nov 23, 2020

JonRowe deleted the move-to-github-actions branch November 23, 2020 09:30

JonRowe added a commit that referenced this pull request Nov 26, 2020

Merge pull request #2404 from rspec/move-to-github-actions

b01ebbe

Move MRI build to Github Actions

JonRowe added a commit that referenced this pull request Dec 26, 2020

Merge pull request #2404 from rspec/move-to-github-actions

3f9640a

Move MRI build to Github Actions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move MRI build to Github Actions #2404

Move MRI build to Github Actions #2404

benoittgt commented Nov 18, 2020 •

edited

pirj left a comment

benoittgt commented Nov 21, 2020

pirj Nov 21, 2020

benoittgt Nov 21, 2020

JonRowe Nov 23, 2020

benoittgt Nov 23, 2020

pirj Nov 23, 2020

JonRowe Nov 22, 2020

benoittgt Nov 22, 2020 •

edited

JonRowe Nov 22, 2020

JonRowe Nov 22, 2020

pirj Nov 22, 2020

pirj Nov 22, 2020

benoittgt Nov 22, 2020

benoittgt commented Nov 22, 2020

pirj commented Nov 23, 2020

benoittgt commented Nov 23, 2020

Move MRI build to Github Actions #2404

Move MRI build to Github Actions #2404

Conversation

benoittgt commented Nov 18, 2020 • edited

pirj left a comment

Choose a reason for hiding this comment

benoittgt commented Nov 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoittgt Nov 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoittgt commented Nov 22, 2020

pirj commented Nov 23, 2020

benoittgt commented Nov 23, 2020

benoittgt commented Nov 18, 2020 •

edited

benoittgt Nov 22, 2020 •

edited