Add Ruby 3.1 for 5-0-maintenance #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
add-ruby-3.1-support-to-rspec-rails-5.0
branch
from
122b4a8
to
347a9e6
Compare
rubygems/bundler#6728 ailure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty expected `"Your RubyGems version (2.7.6.3)) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`\n".empty?` to be truthy, got false
`rspec-rails` 6.0 will support Rails 7
Add additional logic to the ActionMailer argument parsing to accomodate for differences under Ruby 3.1/Rails 6.1 Co-authored-by: Fabio Napoleoni <f.napoleoni@gmail.com> Co-authored-by: Phil Pirozhkov <hello@fili.pp.ru>
pirj
force-pushed
the
add-ruby-3.1-support-to-rspec-rails-5.0
branch
from
21b462c
to
b020050
Compare
Exclude both the "bundle" and "tmp" directory. The former ensures we don't run rubocop against installed gems. The latter ensures we don't run it against generated code and apps locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
3.0that were actually running against Ruby 3.2-devmasterthat is now Rails 7.1enqueued_mail