Fix tests to expect a non-match, not an error #2728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rspec/rspec-expectations#1449, the `Include` matcher is fixed so that it doesn't raise an error when types don't match. Instead, the actual and expected will be deemed to not match.
pirj
reviewed
Feb 2, 2024
pirj
reviewed
Feb 2, 2024
| @@ -79,12 +79,7 @@ def new_record?; true; end | |||
|
|
|||
| context "matcher is wrong type" do | |||
| it "fails" do | |||
| expect { | |||
| expect(record).to be_a_new(record.class).with( | |||
| foo: a_hash_including({ no_foo: "foo" })) | |||
There was a problem hiding this comment.
What if we just use a different "wrong type" of matcher here and keep the example as is? Like be_within/cover/contain_exactly.
At the same time, this example won't break after your rspec-expectations fix.
|
Closing as the root PR was closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rspec/rspec-expectations#1449, the
Includematcher is fixed so that it doesn't raise an error when types don't
match. Instead, the actual and expected will be deemed to not match.