Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package #4

Closed
dustinmoris opened this issue Aug 6, 2017 · 2 comments
Closed

NuGet package #4

dustinmoris opened this issue Aug 6, 2017 · 2 comments

Comments

@dustinmoris
Copy link

Hi, first of all thanks for building this fancy task builder! From my first few tests it works like a charm! I came across it, because someone used your TaskBuilder.fs to improve the performance of the Giraffe web framework and therefore I would be interested in consuming it via a NuGet package rather than having to copy/paste it every time you improve it or bug fix something. It would also make it easier by having it as a well documented dependency and avoid other contributors to try and change the TaskBuilder.fs in Giraffe when really they should probably discuss any changes/improvements with you here first so that everyone can benefit from it.

Would you be interested in making your TaskBuilder.fs accessible via a NuGet library? If yes I can even help out with a PR myself. Let me know and thank you for open sourcing it!

@rspeele
Copy link
Owner

rspeele commented Aug 7, 2017

I'm in favor of it in principle. I don't know whether it should be a package including the source file or a compiled .dll, but I guess people can always grab the source themselves if they prefer to do it that way...

Anyway, feel free to open a PR!

@NinoFloris
Copy link

NinoFloris commented Aug 17, 2017

If this happens you might also want to add/change the Obsolete attribute on the TaskBuilder to just use EditorBrowsable(EditorBrowsableState.Never) as it's in a different assembly that should work.

ForNeVeR added a commit to ForNeVeR/TaskBuilder.fs that referenced this issue Oct 4, 2017
ForNeVeR added a commit to ForNeVeR/TaskBuilder.fs that referenced this issue Oct 5, 2017
ForNeVeR added a commit to ForNeVeR/TaskBuilder.fs that referenced this issue Oct 5, 2017
@ForNeVeR ForNeVeR mentioned this issue Oct 5, 2017
ForNeVeR added a commit to ForNeVeR/TaskBuilder.fs that referenced this issue Oct 6, 2017
@rspeele rspeele closed this as completed in #8 Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants