Add SelectionOptions type and refactor GetThermostat to use them #15
Conversation
There was a problem hiding this comment.
Sorry for the delayed review, April and early May were something special...
Anyway, thank you for the PR. A few very minor tweaks if you don't mind...
Originally, the option funcs were all With but that seemed redundant, so removed the With.
I agree the With is providing much value, but the option func pattern generally uses it, so in the name of consistency, maybe add them back? (Or you could probably convince me I'm being silly about that.)
I can undo the formatting changes made by gofmt if you prefer.
Yes please. I'm not opposed to the changes, but let's make them outside the scope of this PR. Also, what version of gofmt are you using? 1.22 isn't making those changes for me.
| @@ -82,6 +81,11 @@ func (c *Client) GetThermostat(thermostatID string) (*Thermostat, error) { | |||
| IncludeSensors: true, | |||
| IncludeWeather: false, | |||
| } | |||
|
|
|||
| for _, optfn := range opts { | |||
There was a problem hiding this comment.
just o is ok here. Or opt if you'd prefer. The scope is one line, there won't be any confusion.
I try to follow the Google Go style guide
I wanted to be able to configure GetThemostat selection data, and you have a TODO to allow for this, so I created a SelectionOption type which can be passed into GetThermostat to set specific selection options when making a request.
I modified the GetThermostat to take the options as a variadic parameter, so the change should be backwards compatible.
Originally, the option funcs were all
With<SettingName>but that seemed redundant, so removed the With.I can undo the formatting changes made by gofmt if you prefer.