Do not create a scope reference for identifier in DotAccessor

rspivak · Jun 6, 2011 · 5be8228 · 5be8228
1 parent 8aae166
commit 5be8228
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/slimit/tests/test_mangler.py b/src/slimit/tests/test_mangler.py
@@ -81,9 +81,9 @@ class ManglerTestCase(unittest.TestCase):
            var b = 'indeed', c = 5;
            global_x = 56;
            console.log(a + b);
-           new_result = function(d, e) {
-             var e = 'qwerty';
-             console.log(a + b + d + e + global_x);
+           new_result = function(c, d) {
+             var d = 'qwerty';
+             console.log(a + b + c + d + global_x);
            };
          };
          """),

diff --git a/src/slimit/visitors/scopevisitor.py b/src/slimit/visitors/scopevisitor.py
@@ -118,6 +118,10 @@ def visit_FuncDecl(self, node):
     # alias
     visit_FuncExpr = visit_FuncDecl
 
+    def visit_DotAccessor(self, node):
+        # we skip identifier
+        self.visit(node.node)
+
     def visit_Identifier(self, node):
         if getattr(node, 'scope', None) is not None:
             self._fill_scope_refs(node.value, node.scope)