Impact field for finding

migrations/versions/f77b23eeee22_.py

@@ -0,0 +1,30 @@
+"""empty message
+
+Revision ID: f77b23eeee22
+Revises: 3277e0ef1496
+Create Date: 2024-02-08 09:07:11.683010
+
+"""
+from alembic import op
+import sqlalchemy as sa
+import sarna
+
+
+# revision identifiers, used by Alembic.
+revision = 'f77b23eeee22'
+down_revision = '3277e0ef1496'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+# Create impact columns for finding + translation
+    op.add_column('finding', sa.Column('impact', sa.String(), nullable=True))
+    op.add_column('finding_template_translation', sa.Column('impact', sa.String(), nullable=True))
+
+
+def downgrade():
+# ### commands auto generated by Alembic - please adjust! ###
+    op.drop_column('finding_template_translation', 'impact')
+    op.drop_column('finding', 'impact')
+    # ### end Alembic commands ###

sarna/model/finding.py

@@ -40,6 +40,7 @@ class Finding(Base, db.Model):
         AttributeConfiguration(name='owasp_mobile_category', **supported_serialization),
         AttributeConfiguration(name='owisam_category', **supported_serialization),
         AttributeConfiguration(name='description', **supported_serialization),
+        AttributeConfiguration(name='impact', **supported_serialization),
         AttributeConfiguration(name='solution', **supported_serialization),
         AttributeConfiguration(name='tech_risk', **supported_serialization),
         AttributeConfiguration(name='business_risk', **supported_serialization),
@@ -75,6 +76,7 @@ class Finding(Base, db.Model):
     owisam_category = db.Column(Enum(OWISAMCategory))
 
     description = db.Column(db.String())
+    impact = db.Column(db.String())
     solution = db.Column(db.String())
 
     tech_risk = db.Column(Enum(Score), nullable=False)
@@ -217,6 +219,7 @@ def build_from_template(cls, template: FindingTemplate, assessment: Assessment):
             definition=translation.definition,
             references=translation.references,
             description=translation.description,
+            impact=translation.impact,
 
             assessment=assessment,
 

sarna/model/finding_template.py

@@ -70,6 +70,7 @@ class FindingTemplateTranslation(Base, db.Model):
     definition = db.Column(db.String(), nullable=False)
     references = db.Column(db.String(), nullable=False)
     description = db.Column(db.String())
+    impact = db.Column(db.String())
 
     def check_references_urls(self):
         url_regex = r"\[.+\]\((.+)\)"