Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect QueueRunnerThread implementation #8

Closed
th0br0 opened this issue Sep 30, 2012 · 1 comment
Closed

Incorrect QueueRunnerThread implementation #8

th0br0 opened this issue Sep 30, 2012 · 1 comment

Comments

@th0br0
Copy link

th0br0 commented Sep 30, 2012

The current QueueRunnerThread implementation returns a handler to the future upon creation.

However, this handler is not being passed an instance of the HandlerThread's looper!
The looper is only available once HandlerThread.onLooperPrepared has been called.

class QueueRunnerThread
  extends HandlerThread( this.toString )
{
  override def onLooperPrepared() = {
    threadHandlerFut.succeed( new Handler(getLooper()) )
  }
}
rst added a commit that referenced this issue Oct 1, 2012
@rst
Copy link
Owner

rst commented Oct 1, 2012

I believe this is now fixed on master... let me know if it still looks off. Thanks!

@rst rst closed this as completed Oct 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants