0.99: 16 failed tests

[dvzrv]

Hi! I'm packaging rst2pdf for Arch Linux.
In #1015 I tried to clear up the required dependencies of this project. As mentioned in #1015 (comment) I am still met with 16 failing tests though.

Description of problem

python -m build --wheel --no-isolation
local _site_packages=$(python -c "import site; print(site.getsitepackages()[0])")


mkdir -vp test_dir
python -m installer --destdir=test_dir dist/*.whl

export PYTHONPATH="$PWD/test_dir/$_site_packages:$PYTHONPATH"
export PATH="$PWD/$_test_dir/usr/bin:$PATH"
pytest -vv

leads to:

=========================== short test summary info ============================
FAILED rst2pdf/tests/input/test_box_widths.rst::test_box_widths
FAILED rst2pdf/tests/input/test_header_footer_in_stylesheet.rst::test_header_footer_in_stylesheet
FAILED rst2pdf/tests/input/test_issue_110.rst::test_issue_110
FAILED rst2pdf/tests/input/test_issue_110_2.rst::test_issue_110_2
FAILED rst2pdf/tests/input/test_issue_110_3.rst::test_issue_110_3
FAILED rst2pdf/tests/input/test_issue_126.rst::test_issue_126
FAILED rst2pdf/tests/input/test_issue_261.rst::test_issue_261
FAILED rst2pdf/tests/input/test_issue_274_2.rst::test_issue_274_2
FAILED rst2pdf/tests/input/test_issue_288.rst::test_issue_288
FAILED rst2pdf/tests/input/test_issue_295.rst::test_issue_295
FAILED rst2pdf/tests/input/test_preprocessor.rst::test_preprocessor
FAILED rst2pdf/tests/input/test_raw_html.rst::test_raw_html
FAILED rst2pdf/tests/input/test_stylesheet_includes.rst::test_stylesheet_includes
FAILED rst2pdf/tests/input/test_table_in_header.rst::test_table_in_header
FAILED rst2pdf/tests/input/test_uml_extension.rst::test_uml_extension
FAILED rst2pdf/tests/input/sphinx-footnotes-order/conf.py::sphinx-footnotes-order
============ 16 failed, 275 passed, 22 skipped in 152.36s (0:02:32) ============

Full build log:
rst2pdf-0.99-build.log

What is the expected output? What do you see instead?

All tests should pass, but they do not.

🖥 Versions

python -V: Python 3.10.4

pip freeze | grep rst2pdf: n/a (pypi sdist tarball for 0.99)

pip freeze | grep reportlab: 3.6.9

pip freeze | grep Sphinx n/a

Which operating system are you using?

Arch Linux

Additional information
All tests should be possible to be run on all targets or be skipped otherwise to ensure a robust application.

[lornajane]

Thanks for reporting this and sorry for the slow response. One of us will take a look and try to update with some more detail (or even better, fixed tests!)

[lornajane]

I'm seeing the same tests fail on anything that uses Reportlab > 3.6.3 (there isn't a 3.6.4, but I see it in 3.6.5). Spot checking shows that it's changing the spacing in footnotes, so if anyone else is running into this, try pinning the version while we figure out how to either return to the previous behaviour, or update the tests to accommodate it.

[lornajane]

Check this again after #1110 merges - we will update the tests

[dvzrv]

Thanks! It seems now (with 0.100) only test_raw_html is broken:

________________________________ test_raw_html _________________________________
conftest.CompareException: assert 5 == 3
 +  where 5 = len([(163.71572875976562, 85.16615295410156, 432.3948974609375, 98.93614959716797, 'Name\ne-mail\n', 0, ...), (63.02362060546875, 103.11614990234375, 89.70362091064453, 116.85614776611328, 'Pedro\n', 1, ...), (304.6378173828125, 102.99189758300781, 358.69183349609375, 110.20539855957031, 'pedro@mailaddress.es\n', 2, ...), (63.02362060546875, 121.11614990234375, 91.3436279296875, 134.8561553955078, 'Dimitri\n', 3, ...), (304.6378173828125, 120.99189758300781, 358.09857177734375, 128.2053985595703, 'dimitr@mailaddress.es\n', 4, ...)])
 +  and   3 = len([(163.71572875976562, 85.16615295410156, 432.3948974609375, 98.93614959716797, 'Name\ne-mail\n', 0, ...), (63.02362060546875, 103.11614990234375, 89.70362091064453, 116.85614776611328, 'Pedro\n', 1, ...), (63.02362060546875, 121.11614990234375, 91.3436279296875, 134.8561553955078, 'Dimitri\n', 2, ...)])
----------------------------- Captured stdout call -----------------------------
++ Page 1 ++
page_a: [(163.71572875976562, 85.16615295410156, 432.3948974609375, 98.93614959716797, 'Name\ne-mail\n', 0, 0), (63.02362060546875, 103.11614990234375, 89.70362091064453, 116.85614776611328, 'Pedro\n', 1, 0), (304.6378173828125, 102.99189758300781, 358.69183349609375, 110.20539855957031, 'pedro@mailaddress.es\n', 2, 0), (63.02362060546875, 121.11614990234375, 91.3436279296875, 134.8561553955078, 'Dimitri\n', 3, 0), (304.6378173828125, 120.99189758300781, 358.09857177734375, 128.2053985595703, 'dimitr@mailaddress.es\n', 4, 0)]
page_b: [(163.71572875976562, 85.16615295410156, 432.3948974609375, 98.93614959716797, 'Name\ne-mail\n', 0, 0), (63.02362060546875, 103.11614990234375, 89.70362091064453, 116.85614776611328, 'Pedro\n', 1, 0), (63.02362060546875, 121.11614990234375, 91.3436279296875, 134.8561553955078, 'Dimitri\n', 2, 0)]
number of blocks in page_a: 5
number of blocks in page_b: 3
=========================== short test summary info ============================
FAILED tests/input/test_raw_html.rst::test_raw_html

[akrabat]

I have a note that on M1 Macs, I seem to need to do pip install reportlab==3.6.12 --force-reinstall --no-cache-dir --global-option=build_ext to get that test to pass.

I don't know why, though and have a note that I need to investigate this more.

[lornajane]

@dvzrv thanks for the update, that seems better! Can you capture your note as an issue please, @akrabat ? I think I can close this open issue now.