New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate svg2rlg? #745
Comments
We have some svg tests that aren't passing (they are marked as to be ignored) too, so we need to work in this area anyway. There's a few Py3 ports:
|
Also, for testing purposes, I am thinking it may be useful to mock inkscape
so we don't depend on it being a specific version.
Just creating a "fake" inkscape that always returns the same PDF :-)
…On Tue, Feb 12, 2019 at 3:17 PM Rob Allen ***@***.***> wrote:
We have some svg tests that aren't passing (they are marked as to be
ignored) too, so we need to work in this area anyway.
There's aPy3 port here <https://github.com/aquavitae/svg2rlg>, but
doesn't seem very active.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#745 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAGK-QH60B2eLc8v6XsccUSap1GSYMVks5vMwUfgaJpZM4a3rkq>
.
|
Would we use this every time? I think it's quite helpful that we all have different versions of inkscape and could run the tests in different environments as needed. If I upgrade inkscape and that causes a problem, I'd like to know that there's a problem when I run the tests, not when my PDF won't build correctly. |
@akrabat svglib looks promising! Will try to do a PR for it. |
We definitely need it work this way. |
My main concern is that I have never, ever, been able to make inkscape work in my mac. That means I can never successfully run the test suite which adds a lot of friction. |
I'm happy to have a switch that can be enabled for locally testing with a mocked Inkscape output. I can't remember how I installed Inkscape on my Mac mind you. |
It's py2-only, not widely used, and inkscape gives much better results (although yes, it's a pain in OSX)
The text was updated successfully, but these errors were encountered: