Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate svg2rlg? #745

Closed
ralsina opened this issue Feb 12, 2019 · 7 comments
Closed

Deprecate svg2rlg? #745

ralsina opened this issue Feb 12, 2019 · 7 comments

Comments

@ralsina
Copy link
Contributor

ralsina commented Feb 12, 2019

It's py2-only, not widely used, and inkscape gives much better results (although yes, it's a pain in OSX)

@akrabat
Copy link
Member

akrabat commented Feb 12, 2019

We have some svg tests that aren't passing (they are marked as to be ignored) too, so we need to work in this area anyway.

There's a few Py3 ports:

@ralsina
Copy link
Contributor Author

ralsina commented Feb 12, 2019 via email

@lornajane
Copy link
Contributor

Would we use this every time? I think it's quite helpful that we all have different versions of inkscape and could run the tests in different environments as needed. If I upgrade inkscape and that causes a problem, I'd like to know that there's a problem when I run the tests, not when my PDF won't build correctly.

@ralsina
Copy link
Contributor Author

ralsina commented Feb 13, 2019

@akrabat svglib looks promising! Will try to do a PR for it.

@akrabat
Copy link
Member

akrabat commented Feb 13, 2019

If I upgrade inkscape and that causes a problem, I'd like to know that there's a problem when I run the tests, not when my PDF won't build correctly.

We definitely need it work this way.

@ralsina
Copy link
Contributor Author

ralsina commented Feb 13, 2019

My main concern is that I have never, ever, been able to make inkscape work in my mac. That means I can never successfully run the test suite which adds a lot of friction.

@akrabat
Copy link
Member

akrabat commented Feb 13, 2019

I'm happy to have a switch that can be enabled for locally testing with a mocked Inkscape output.

I can't remember how I installed Inkscape on my Mac mind you.

akrabat added a commit that referenced this issue Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants