Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links (TOC, sections and figures) have been broken since reportlab updated to 3.5.19 #772

Closed
shamil-ru opened this issue May 6, 2019 · 1 comment · Fixed by #777
Labels
bug Triaged as a bug

Comments

@shamil-ru
Copy link

shamil-ru commented May 6, 2019

When updating reportlab from 3.5.18 to 3.5.19, internal links become unusable.

Description of problem

Check whether reportlab installed has the version 3.5.19.

RST file: toc.rst

===============================
Document with Table of Contents
===============================

-------
Example
-------

.. contents:: Table of Contents
   :depth: 2

Heading 1
=========

Normal, **Bold**, *Italic*.

Heading 2
---------

``Mono``.

Heading 3
~~~~~~~~~

.. code:: python

  #!/usr/bin/env python

  print("Hello, world!")

Run: rst2pdf toc.rst

Open toc.pdf and try to click to table of contents items.

What is the expected output? What do you see instead?
When downgrading reportlab to 3.5.18, links in table of contents work well, but after upgrading they become like heading-1-... etc and don't work.

🖥 Versions

python -V
Python 2.7.16

pip freeze | grep rst2pdf
rst2pdf==0.94

pip freeze | grep reportlab
reportlab==3.5.19

pip freeze | grep Sphinx

(Optional) wordaxe version :

Which operating system are you using?

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=19.04
DISTRIB_CODENAME=disco
DISTRIB_DESCRIPTION="Ubuntu 19.04"
Linux 5.0.0-13-generic #14-Ubuntu SMP Mon Apr 15 14:59:14 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Additional information

I guess this commit breaks the compatibility:
https://bitbucket.org/rptlab/reportlab/commits/c46115a85b61f4822026e72f5949a4fb1b63ba73

@akrabat
Copy link
Member

akrabat commented Jun 2, 2019

PDFs that don't work:

toc.pdf is the generated PDF from the above rest:
toc.pdf

Test issue 110: click the links in the footer to go back:
test_issue_110.pdf

@akrabat akrabat added the bug Triaged as a bug label Jun 2, 2019
akrabat added a commit to akrabat/rst2pdf that referenced this issue Jun 2, 2019
@oz123 oz123 closed this as completed in #777 Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Triaged as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants