Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to mark new known good md5s in tests #865

Closed
lornajane opened this issue May 21, 2020 · 2 comments
Closed

Explain how to mark new known good md5s in tests #865

lornajane opened this issue May 21, 2020 · 2 comments

Comments

@lornajane
Copy link
Contributor

lornajane commented May 21, 2020

We updated the instructions for running the tests but not for marking the md5 hashes as good or not, so the instructions for working with the tests are not complete enough for a new contributor at this point.

Solution: extend the doc/DEVELOPERS.rst file to include updated instructions (look at older versions of the file, we moved from autotest to pytest and these instructions got lost along the way)

@stephenfin
Copy link
Contributor

I think this can be closed now, since we're no longer using the checksum-based machinery? (:raised_hands:)

@akrabat
Copy link
Member

akrabat commented Jun 7, 2020

I think this can be closed now, since we're no longer using the checksum-based machinery? (🙌)

Agreed.

Also #872 adds better info to docs/DEVELOPERS.rst on how to test.

@akrabat akrabat closed this as completed Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants