Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup remnants of MD5-based testing suite #872

Merged
merged 2 commits into from Jun 7, 2020
Merged

Cleanup remnants of MD5-based testing suite #872

merged 2 commits into from Jun 7, 2020

Conversation

stephenfin
Copy link
Contributor

Remove the giant md5 directory and update some docs to reference the new world.

akrabat
akrabat requested changes Jun 7, 2020
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation changes in DEVELOPERS are very helpful, thanks.

However, we can't change the symbols used for headings unless we also resolve how to integrate with the manual, which is best considered separately.

doc/DEVELOPERS.rst Outdated Show resolved Hide resolved
@akrabat akrabat mentioned this pull request Jun 7, 2020
Closed
@stephenfin
tests: Remove 'md5' directory
0850da8 
With the switch to a content-based testing scheme, we no longer need
these things. Adios!

Signed-off-by: Stephen Finucane <stephen@that.guru>
@stephenfin
docs: Update DEVELOPER docs to reflect the MD5-less world
1dfbc40 
Things are a-changing in rst2pdf land. Let everyone know.

Signed-off-by: Stephen Finucane <stephen@that.guru>
akrabat
akrabat approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akrabat akrabat closed this in 0f13381 Jun 7, 2020
@akrabat akrabat merged commit 0f13381 into rst2pdf:master Jun 7, 2020
@stephenfin stephenfin deleted the cleanup-md5-directory branch June 7, 2020 20:21
@akrabat akrabat added this to the 1.0 milestone Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.98
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephenfin @akrabat