Resize an image in a table cell if it is taller than the page height #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrabat
force-pushed
the
resizing-image-in-figure
branch
from
745ea66
to
3a5a21d
Compare
When it is used in in reference PDFs at full size, it may result in a file that's bigger than the pre-commit checks allow.
An image cannot be rendered across a page boundary and so if it is too tall, then it needs to be resized. This happens automatically for plain images, but not for those in a table (including lists and figures in rst2pdf). This is because the availHeight parameter passed to wrap() is set to a very large value by reportlab on the assumption that a table cell's data can be rendered over a page boundary. We therefore need to set the correct maximum height into the MyImage instances within a DelayedTable so that they can be resized correctly.
While figures are also tables, we can't be sure that they always will be and so we test that an image in a table that's too tall for the page is corrrectly resized.
akrabat
force-pushed
the
resizing-image-in-figure
branch
from
65c9e4c
to
fdad526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An image cannot be rendered across a page boundary and so if it is too tall, then it needs to be resized. This happens automatically for plain images, but not for those in a table (including lists and figures in rst2pdf).
This is because the availHeight parameter passed to wrap() is set to a very large value by reportlab on the assumption that a table cell's data can be rendered over a page boundary. We therefore need to set the correct maximum height into the MyImage instances within a DelayedTable so that they can be resized correctly.
Fixes #966.
@nfraprado: I would appreciate your review.