UML test: new checksum but reference PDF is missing #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Installing plantuml via brew, I get the same looking PDF as you do. Please add the PDF to tests/reference as part of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on Ubuntu 17.10 and have the following software versions:
apt-get install plantuml)The test
test_uml_extensionproduces a different md5 than the test suite expects, which isn't a surprise as I am using a newer version of inkscape. I couldn't find the reference PDF for this test though. If the attached PDF looks right, then merge this PR to accept the new md5 into the mix and let me know if I should also add the PDF into the repo. Otherwise, just close or let me know if I can do further testing.test_uml_extension.pdf