Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exceptions py3 ready #657

Merged
merged 2 commits into from Apr 27, 2018
Merged

Make exceptions py3 ready #657

merged 2 commits into from Apr 27, 2018

Conversation

ralsina
Copy link
Contributor

@ralsina ralsina commented Apr 27, 2018

  • Make except statements py3-compatible
  • Fail to run setup.py at all if py3 is used.

@oz123
Copy link
Collaborator

oz123 commented Apr 27, 2018

Welcome back!

@oz123 oz123 merged commit e0f0f7f into master Apr 27, 2018
@ralsina
Copy link
Contributor Author

ralsina commented Apr 27, 2018

Thanks!

Just got bored of seeing the same issue being reopened over and over :-D

@akrabat akrabat added this to the 0.94 milestone Apr 27, 2018
@oz123
Copy link
Collaborator

oz123 commented Apr 27, 2018

@ralsina I have also added a classifier in #658

@akrabat akrabat deleted the make-exceptions-py3-ready branch April 28, 2018 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oz123 oz123 oz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.94
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ralsina @oz123 @akrabat