Fix start-at line numbers #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explanation of how each code block is set up so that it's easier to determine if the test is correct.
As we have walked back to the start of the line, the calculation of line_offset is one too high.
The :start-at: line numbers are now correct.
|
Note, that as the Run the test locally with: And check that output/test_issue_310.pdf matches reference/test_issue_310.pdf - specifically the second test should now have line numbers that start at 3, not 2. |
|
This looks good to me, the line numbers are fixed and my output matches the reference doc. I get a new md5 though, that you might like to add? It's |
akrabat
added a commit
to akrabat/rst2pdf
that referenced
this pull request
May 4, 2018
|
Thanks @lornajane! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test_issue_310, the line numbers for the :start-at: test when using :linenos_offset: are off by one.
Addresses one of the problems with #662.