Decode output of fc-match in Python2 as UTF-8 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralsina
reviewed
Mar 6, 2019
rst2pdf/findfonts.py
Outdated
| @@ -193,6 +194,8 @@ def get_family(query): | |||
|
|
|||
| def get_fname(query): | |||
| data = os.popen("fc-match -v \"%s\""%query, "r").read() | |||
There was a problem hiding this comment.
maybe change this to use subprocess.check_output? Just so it looks less 2010 ish :-)
|
Will do.
… On 6 Mar 2019, at 21:03, Roberto Alsina ***@***.***> wrote:
@ralsina commented on this pull request.
In rst2pdf/findfonts.py:
> @@ -193,6 +194,8 @@ def get_family(query):
def get_fname(query):
data = os.popen("fc-match -v \"%s\""%query, "r").read()
maybe change this to use subprocess.check_output? Just so it looks less 2010 ish :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
ralsina
approved these changes
Mar 7, 2019
If the output of fc-match contains any unicode characters, then we need to handle this in Python 2. Fixes rst2pdf#757
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the output of fc-match contains any unicode characters, then we need to handle this in Python 2.
Fixes #757