Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding badges to README #798

Merged
merged 1 commit into from Sep 6, 2019
Merged

Adding badges to README #798

merged 1 commit into from Sep 6, 2019

Conversation

Lucas-C
Copy link
Contributor

@Lucas-C Lucas-C commented Sep 5, 2019 •
edited

@akrabat
Copy link
Member

akrabat commented Sep 5, 2019

I like it!

@akrabat
Copy link
Member

akrabat commented Sep 5, 2019 •
edited

Hmm. I'm not sure I want Python 3 badges on the README as people will expect to be able to install via pip if they see a Python 3 badge.

Update: Seems that the badge looks on PyPI, not in setup.py anyway.

akrabat
akrabat requested changes Sep 5, 2019
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lucas-C Updating setup.py is a separate task from adding badges to the README. Please remove the setup.py change.

@Lucas-C
Copy link
Contributor Author

Lucas-C commented Sep 5, 2019

Ok, as you wish. Done

@akrabat akrabat closed this in 48b163f Sep 6, 2019
@akrabat akrabat merged commit d64108e into rst2pdf:master Sep 6, 2019
@akrabat akrabat added this to the 0.95 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.95
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lucas-C @akrabat