Use correct argument to 'inkscape' #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use black [1] to clean things up a little here. [1] https://black.readthedocs.io/en/stable/ Signed-off-by: Stephen Finucane <stephen@that.guru>
Inkscape 1.0 final has replaced the '--export-file' argument with '--export-filename' [1]. Update our calls accordingly. [1] https://wiki.inkscape.org/wiki/index.php/Release_notes/1.0#Command_Line Signed-off-by: Stephen Finucane <stephen@that.guru> Closes: rst2pdf#869
This cross-platform function has existed since Python 3.3 [1]. Since we only care about that now, we can use this instead of hardcoding the path. [1] https://docs.python.org/3/library/shutil.html#shutil.which Signed-off-by: Stephen Finucane <stephen@that.guru>
akrabat
reviewed
Jun 7, 2020
akrabat
reviewed
Jun 7, 2020
akrabat
added a commit
to stephenfin/rst2pdf
that referenced
this pull request
Jun 7, 2020
akrabat
approved these changes
Jun 7, 2020
|
hmm.. tried to force a re-run of Travis, |
Merged
akrabat
added a commit
to akrabat/rst2pdf
that referenced
this pull request
Dec 4, 2020
Backport of PR rst2pdf#870 (68d4ed7): > Inkscape 1.0 final has replaced the '--export-file' argument > with '--export-filename' [1]. Update our calls accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #869, inkscape 1.0 final uses '--export-filename' - not '--export-file'. This was causing test failures on Fedora 31.
While we're here, we take the opportunity to clean up this file, replacing some hardcoded paths on Windows and running the whole thing through black. We can do a lot more of the latter as we proceed with fixing various bugs and removing all the skipped tests.