Use 'pytest.fail' instead of 'assert' in test #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use the latter, we see a really ugly, hard-to-parse traceback. The latter is much more subtle so use that. The 'pytrace' variable is set to False on all values to avoid triggering a full traceback from 'pytest.fail' also [1]. [1] https://docs.pytest.org/en/stable/reference.html#pytest-fail Signed-off-by: Stephen Finucane <stephen@that.guru>
Resolve a small bug in our reference PDF to generated PDF comparison, whereby a missing reference PDF will generate the following failure: Mismatch between type of output (file) and reference (dir) This will now return the following: No reference file at 'rst2pdf/tests/reference/foo' to compare against Signed-off-by: Stephen Finucane <stephen@that.guru>
|
We can improve this further by including the output log in the response too. I can do this in a follow up |
Rather than having to cat this stuff yourself, show it on the screen. Use a consistent function for this. Signed-off-by: Stephen Finucane <stephen@that.guru>
akrabat
approved these changes
Jun 7, 2020
|
This is much nicer for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use the latter, we see a really ugly, hard-to-parse traceback. The latter is much more subtle so use that.
The 'pytrace' variable is set to False on all values to avoid triggering a full traceback from 'pytest.fail' also [1].