Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some doc nits #878

Merged
merged 3 commits into from Jun 20, 2020
Merged

Address some doc nits #878

merged 3 commits into from Jun 20, 2020

Conversation

stephenfin
Copy link
Contributor

  • Mark some code blocks in the README as such
  • Add a summary of Sphinx integration
  • Remove some Python 2'isms from the manual

We need to precede things with '::' for them to render correctly.

A typo is corrected.

Signed-off-by: Stephen Finucane <stephen@that.guru>
rst2pdf only supports Python 3 now, which means the unicode string
prefix is unnecessary - strings are unicode by default in Python 3.

We also fix some formatting so people copy-pasting the configuration
into 'conf.py' files won't have to immediately resolve PEP8 issues.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Mention support for Sphinx by way of a quick intro. People seeking more
information can refer to the manual.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Closes: rst2pdf#535
@akrabat
Copy link
Member

akrabat commented Jun 20, 2020

Rebased to pick up changes to README.rst

@akrabat akrabat added this to the 1.0 milestone Jun 20, 2020
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akrabat akrabat merged commit 9c13a28 into rst2pdf:master Jun 20, 2020
@stephenfin stephenfin deleted the readme-tweaks branch June 20, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants