Update syntax highlight styles #882
Conversation
|
Updated to say that the newly generated/updated styles do seem to work pretty well. Going to put this PR to not-draft status in case anyone else has an opinion on what else we should do before merging. I'll add a list of styles to the documentation I think as I'm not sure how else they can be discovered. |
| * ``autumn`` | ||
| * ``borland`` | ||
| * ``bw`` | ||
| * ``colorful`` | ||
| * ``default`` |
There was a problem hiding this comment.
Is this style picked up as the default colour scheme if the user doesn't explicitly choose another one?
There was a problem hiding this comment.
Yes, this seems to be our default as well as the pygments default style (which is updated by this PR). I get the same output with and without the "default" stylesheet.
lornajane
force-pushed
the
update-pygments-styles
branch
from
6ff7b2d
to
c97c096
Compare
|
Rebased to eliminate conflicts from style fixes |
lornajane
changed the title
|
Do we need to do anything else before we can merge this styles PR? |
Fixed ordering and added change entry for rst2pdf#882 that was missed when it was merged.
Looking at #761 and digging around in the codebase, I found
pygments2style.pywhich does indeed contain the code that takes in whatever pygments styles are on your computer and turn them into rst2pdf styles. So I've started by dumping the output of that into this branch, it needs more testing and also some investigation into what's now available in pygments that we might not already have support for in rst2pdf.