Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #916

Merged
merged 1 commit into from Sep 9, 2020
Merged

Fix typo #916

merged 1 commit into from Sep 9, 2020

Conversation

stephenfin
Copy link
Contributor

We were inadvertently comparing a string against itself. It seems we
need tests for our tests /o\

Closes: #910

We were inadvertently comparing a string against itself. It seems we
need tests for our tests /o\

Signed-off-by: Stephen Finucane <stephen@that.guru>
Closes: rst2pdf#910
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! That's an easy one to miss!

@akrabat akrabat merged commit 19f95b6 into rst2pdf:master Sep 9, 2020
@akrabat
Copy link
Member

akrabat commented Sep 9, 2020

Thanks @stephenfin

@akrabat akrabat added this to the 0.99 milestone Sep 9, 2020
@stephenfin stephenfin deleted the issues/910 branch September 9, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test pass even when PDF's are different
2 participants