tests/rename_for_verbosity_pt1 - rename issue test names for verbosity #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
realised i renamed the output files instead of reference. I am getting different output on 68_1 from reference file - not sure if intentional but going to revert the content change on those two so that there's parity. |
|
Thanks for this work. With the merging of #951, you'll need to rebase against |
Renamed the tests for issues < 100 so that they're easier to understand in logs when they fail.
…bosity Renamed the reference files so tests pass with matching files..
After checking the output of the tests with the longer filenames, I noticed weird spacing within the 1st paragraph (as if justified alignment was being applied. Since this task is purely about renaming the tests, I've reverted the contents of the test files
BinaryKitten
force-pushed
the
tests/rename_for_verbosity_pt1
branch
from
bb663fb
to
9d8c6b0
Compare
lornajane
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the tests for issues < 100 so that they're easier to understand in logs when they fail.
Also updated test_issue_68_1 & test_issue_68_2 so that they refer to the renamed files.