Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve person render #4

Closed
wants to merge 1 commit into from
Closed

Conversation

marekkalnik
Copy link

Add displaying date of birth and death
Remove double person.name if no fullname specified

Remove double person.name if not fullname specified
@meyersbs
Copy link

@rstacruz Please merge this!

Copy link

@joepagan joepagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works, I'm not sure about the cross and * characters personally but better to have this than not.
image
@rstacruz can you PR this?

@AlexanderWillner
Copy link

That's great. I'm using it at https://github.com/AlexanderWillner/kingraph and fixed a few bugs around this as well.

@joepagan
Copy link

joepagan commented Feb 6, 2020

Thanks for the heads up @AlexanderWillner I'll give yours a go soon
Update:
tried it & didn't work for me:

Error: mismatched tag in line 1 
... Bob Bob</table> ...
in label of node BobBob
people:
  BobBob:
    name: Bob
    fullname: Bob Bob

@AlexanderWillner
Copy link

@joepagan please test again, found this bug half an hour ago

@joepagan
Copy link

joepagan commented Feb 9, 2020

@AlexanderWillner seems to work now, looks like you've made considerable fixes and stuff, I'll likely use yours as my base going forward, thanks for your work 👍

@marekkalnik
Copy link
Author

Closing to clean up my PRs as this is a dormant depository

@marekkalnik marekkalnik closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants