Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next version update (March 2020) #218

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

Conversation

rstacruz
Copy link
Owner

@rstacruz rstacruz commented Apr 4, 2020

WIP: While this is a work-in-progress, therelease is available under the next tag - try it out with npm install nprogress@next 😉 (draft release notes)

This updates NProgress to keep it up-to-date with 2020 standards.

Major updates

  • Distirbute an ESM build. NProgress is currently a UMD distribution (ie, CommonJS and browser).

  • Add CSS variables support. It should be easier to change the color.

  • Add Sass support. Same goal as above for those who prefer Sass.

  • Types and documentation. This should hopefully make the experience better for TypeScript and VSCode users.

Build process updates

  • Use jest for tests (rather than Mocha and Chai).
  • Use prettier for code formatting.
  • Use microbundle to distribute UMD, ESM, and CommonJS builds.
  • Use yarn for packaging.
  • Use np for publishing.

CI updates

  • Move from Travis CI to GitHub actions.

Deprecations

  • Remove Bower support.
  • Remove component.json support.
  • Remove jspm support.

Documentation update

  • Update jsdoc comments (with types). This should make the experience better for TypeScript and VSCode users.
  • Move the website to the gh-pages branch.
  • Update the website a bit.
  • Update README.
  • Update CONTRIBUTING.md for notes on maintenance.
  • Migrate changelog to GitHub releases

CSS updates

  • Add CSS variables support
  • Add Sass support

@anselal
Copy link

anselal commented Apr 4, 2020

Nicely done so far, keep up the good work.
FYI, your "little" project is used widely, so you done right to update the js file to keep up with 2020 standards as well adding sass support so it can be used with new JS frameworks !!!

@anselal
Copy link

anselal commented Apr 18, 2020

I created a PR for css variables

@anselal
Copy link

anselal commented Apr 21, 2020

Looking good my friend. Keep up the good work !!!

@vvo
Copy link

vvo commented Jun 10, 2020

Just chiming in to say: I just tried @next release and it worked perfectly. Only thin I had to change was the CSS import, to import "nprogress/css/nprogress.css"; Thanks for working on upgrading the library, it's a great library. I recently used it in a Next.js project to show the progress bar, after a delay, on Route en fetch events (https://dev.to/vvo/show-a-top-progress-bar-on-fetch-and-router-events-in-next-js-4df3)

@vvo
Copy link

vvo commented Jun 11, 2020

@rstacruz For what it's worth: I did some more testing and on iOS Safari the behavior of the progress bar is different than before. When start() is called and it takes a "long" (like 3s) time before done(), the bar progress is not smooth. It jumps back and forth constantly like it's freezing.

I was able to reproduce the behavior in a very simple example (using @next):

Demo:
RPReplay_Final1591869653

Same CodeSandbox but using @latest instead of @next:

Demo:
RPReplay_Final1591869858

@RamyRais
Copy link

RamyRais commented Sep 14, 2020

Hey, would you be interested to add the ability to render multiple progress bar in one page?
I have this fork and would be nice to combine them.

Copy link

@zenflow zenflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rstacruz This looks amaze-ballss! Looks like it's done, too. Merge & release it! :D

@MickL
Copy link

MickL commented Oct 6, 2021

Hey @rstacruz , adding Sass and TypeScript types is exactly what I was looking for! Seems like you finished all the work already and just the documentation is missing? Also I couldnt find the TypeScript typings so I needed to additionally install @types/nprogress :(

Btw. could you please also make the z-index, top and box-shadow a variable? I have a fixed header so I might need to customize those values.

@silasabbott
Copy link

Just checking up on this—@rstacruz let us know how we can help 🎉

@bombillazo
Copy link

Any update on this package, or has it been abandoned? Would like to know either way what the plan is for this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants