Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pure store #524

Merged
merged 57 commits into from
Jan 8, 2017
Merged

Pure store #524

merged 57 commits into from
Jan 8, 2017

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jan 2, 2017 •
edited
Loading

Details here: #519

Additional notes:

  • Life-cycle events related to installation work on the realpath (which does not have the node_modules folder anymore), so packages that have install scripts, are copied instead of symlinked.
  • Bundled dependencies are ignore for now (they are installed as usual dependencies). To support bundled dependencies some operations have to be made less concurrent (which is probably OK).

Should solve: #400, #397, #315

Should allow implementing of: #508 (Offline support)

@zkochan zkochan mentioned this pull request Jan 2, 2017
Open
@zkochan zkochan force-pushed the pure-store branch 2 times, most recently from cf7e41f to cd33ab8 Compare January 2, 2017 21:34
@rstacruz
Copy link
Member

rstacruz commented Jan 4, 2017

Maybe we'll have to make the dependency trees flat as npm and yarn.

Yeah... in hindsight this seems like a good idea now.

rstacruz
rstacruz reviewed Jan 4, 2017
View reviewed changes
README.md
@@ -27,21 +27,37 @@ Follow the [pnpm Twitter account](https://twitter.com/pnpmjs) for updates.

## Background

`pnpm` maintains a flat storage of all your dependencies in `node_modules/.store`. They are then symlinked wherever they're needed.
`pnpm` maintains a flat storage of all your dependencies in `~/.store`. They are then symlinked wherever they're needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not ~/.pnpm/store or ~/.pnpm-store?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because hopefully we will use the same store structure as ied. Though maybe .pnpm-store is a good idea till the specs are not finished

src/api/constantDefaults.ts
@@ -1,2 +1,2 @@
export const GlobalPath = '~/.pnpm'
export const GlobalStorePath = GlobalPath + '/.store'
export const GlobalStorePath = '~/.store'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think usual custom conventions are more like GLOBAL_PATH = '~/.pnpm' but thats just a preference for me :)

@zkochan
Copy link
Member Author

zkochan commented Jan 4, 2017

Maybe we'll have to make the dependency trees flat as npm and yarn.

Yeah... in hindsight this seems like a good idea now.

I thought there would be problems with long directory names but I came up with this idea of "node_modules/.resolutions" folder which is kinda the old store with the node_modules included. So flat trees can be avoided in this PR.

@zkochan zkochan force-pushed the pure-store branch 2 times, most recently from a4409ab to 0529082 Compare January 7, 2017 14:26
@zkochan zkochan mentioned this pull request Jan 8, 2017
Merged
@zkochan
feat: drop Node.js <= 6.3 support
b5df426 
BREAKING CHANGE:

drop support of Node.js pre-6.3
@zkochan
refactor: remove the redundant subfolder in store
ae00bd0
@zkochan
refactor: rename linkPeers
8887f8d
@zkochan
refactor: remove not used code
0ee6573
@zkochan
feat: link each file separately
7af1f93
@zkochan
refactor: change store structure
7b07e01
@zkochan
refactor: resolve github dependencies to commits
1afead5
@zkochan
chore(package.json): pass --preserve-symlinks to ts-node
93b2110
@zkochan
test: temporarily skip failing tests
b4060e6
@zkochan
refactor(git): use more human-friendly Git IDs
197b2dc
@zkochan
refactor: resolve
614a663
@zkochan
refactor: divide resolution and fetching
799fe1d
@zkochan
refactor(fetch): better variable naming
e5bae85
@zkochan
feat: add shrinkwrap.yaml
3be672c
@zkochan
test(shrinkwrap): shrinkwrap locks dependencies
09fe82c
@zkochan
style: fix typing issue
8d91735
@zkochan
fix(fetch): properly link node_modules on repeat install
bf2e992
@zkochan
refactor: comment skipped test with single-line comments
24b965b
@zkochan
fix: circular symlinks are avoided
4da3469
@zkochan
perf: resolve a package only once per project
4737fda
@zkochan
test: concurrent installation of the same dependency
e9d7238
@zkochan
fix: packages are not removed in the middle of fetch
e8d04cc
@zkochan
fix: dependencies are linked only once
8b73918
@zkochan
fix: make linking work on Windows
ed2d72b
@zkochan
fix: installing local dependencies on Windows
c6ddda1
@zkochan
fix: don't reinstall dependencies of the same package
b8747f5
@zkochan
fix(bin): the run function always returns a Promise
041adae
@zkochan
fix: use hard links to link files to the .resolutions folder
a5658f4
@zkochan
fix: bundled dependencies are not reinstalled
90121ab
@zkochan
fix: peers are linked into the correct location
de657e6
@zkochan
refactor: remove unsymlink
6ea6f91 
It is not used anymore
@zkochan
refactor: use UPPER_CASE for constants
4bfe497
@zkochan
chore(CI): test on Node.js v4 as well
96ac7fd
@zkochan
chore(package): return support of Node.js v4
edc1e57
@zkochan
fix: make pnpm Node.js 4 compatible again
6e8b133
@zkochan
test: don't run tsnode with --preserve-symlinks
d550498 
--preserve-symlinks makes tests fail on Node.js 4
@zkochan
fix(bin): don't use --preserve-symlinks on Node pre-6.3
a6ba83d
@zkochan
test: use global stores in tests
b92feee
@zkochan
fix: flat-tree installation should not work on Node 4
437cf8a
@zkochan
fix: show warning
c6ac9c3 
When trying to install into a node_modules created by older pnpm
@zkochan
refactor: change the global store location
efc0a2b 
From `~/.store` to `~/.pnpm-store`
@zkochan
docs: note that some of the info is out of date
130bbcd
@zkochan zkochan merged commit 38837b1 into master Jan 8, 2017
@zkochan zkochan deleted the pure-store branch January 8, 2017 13:47
@iamstarkov
Copy link
Contributor

oh, shi~ thats a huge pr. good job, @zkochan!

@zkochan zkochan mentioned this pull request Jan 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstacruz rstacruz rstacruz left review comments

Assignees
No one assigned
Labels
state: ready for CR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zkochan @rstacruz @iamstarkov