Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 support #81

Merged
merged 14 commits into from
Sep 22, 2022
Merged

React 18 support #81

merged 14 commits into from
Sep 22, 2022

Conversation

rstacruz
Copy link
Owner

Thanks lreddickGNA for starting this with #80! This is a re-implementation of his PR to add React 18 support, but without removing the custom adapter support.

@rstacruz rstacruz marked this pull request as draft September 21, 2022 08:31
@rstacruz rstacruz marked this pull request as ready for review September 21, 2022 09:02
@rstacruz
Copy link
Owner Author

@lreddickGNA Did you get a chance to test this? :-)

@rstacruz
Copy link
Owner Author

rstacruz commented Sep 22, 2022

Tests are a bit of a mess and doesn't even run on CI :( Addressing that in a separate PR:

@rstacruz rstacruz merged commit 5c26964 into master Sep 22, 2022
@rstacruz rstacruz deleted the upgrade-react-18 branch September 22, 2022 14:09
@lreddickGNA
Copy link

lreddickGNA commented Sep 22, 2022

@rstacruz awesome stuff! When do you think the new version will be published to npm?

@rstacruz
Copy link
Owner Author

Unfortunately I'm having trouble with my npm account at the moment so I'm not sure :(

@rstacruz
Copy link
Owner Author

rstacruz commented Sep 23, 2022

Btw, caveat - React 18 stopped supporting IE11, so Remount v0.11 will be the last version to support IE11. Releases after that will not officially support IE11.

There's still code in Remount to support IE11 for now, simply because we haven't had a chance to remove them yet (eg, the mutationobserver workaround because IE11 has no web components support). Presumably we'll be removing those bits as we go.

Related links:

@rstacruz
Copy link
Owner Author

rstacruz commented Sep 30, 2022

Published a pre-release as remount@0.12.0-0 (or remount@next), give it a try! Just a few checks, then I'll publish it under the latest tag @lreddickGNA @jekku

EDIT: now out as remount@1.0.0 - https://github.com/rstacruz/remount/releases/tag/v1.0.0

@lreddickGNA
Copy link

@rstacruz awesome! I will update our project package json to reflect the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants