Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomizer adds song of a recently played artist into the queue #12

Closed
2 tasks done
rstemmer opened this issue Oct 29, 2018 · 1 comment
Closed
2 tasks done

Randomizer adds song of a recently played artist into the queue #12

rstemmer opened this issue Oct 29, 2018 · 1 comment
Assignees
@rstemmer
Labels
🐞 Bug Crash or unexpected behavior ‼️ Urgent ‼️ Needs to be fixed ASAP - MusicDB won't work without that fix

Comments

@rstemmer
Copy link
Owner

rstemmer commented Oct 29, 2018 •
edited

The random song selection algorithm inserted a song from the same artist the song before was (added by me) into the queue

Problem: The randomizer does not track songs added by the user. So that artist was not on the blacklist. This was implemented by intention, but obviously was a bad decision.

Solution: Also add user selection to the blacklists.

  • Move blacklist handling from Randy into different class/file
  • Update Randy/SongQueue classes
@rstemmer rstemmer added 🐞 Bug Crash or unexpected behavior ‼️ Urgent ‼️ Needs to be fixed ASAP - MusicDB won't work without that fix labels Oct 29, 2018
@rstemmer rstemmer self-assigned this Oct 29, 2018
@rstemmer
Copy link
Owner Author

Fixed in 4.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstemmer rstemmer

Labels
🐞 Bug Crash or unexpected behavior ‼️ Urgent ‼️ Needs to be fixed ASAP - MusicDB won't work without that fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rstemmer