Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exact comparison of valueNew and value #1039

Merged
merged 2 commits into from
Dec 13, 2022
Merged

exact comparison of valueNew and value #1039

merged 2 commits into from
Dec 13, 2022

Conversation

stla
Copy link
Collaborator

@stla stla commented Dec 5, 2022

Changed valueNew != value to valueNew !== value. Fixes #1038

yihui
yihui approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a news item in NEWS.md? Thank you!

@yihui yihui merged commit e8e1fb8 into rstudio:main Dec 13, 2022
AhmedKhaled945 pushed a commit to AhmedKhaled945/DT that referenced this pull request Jul 5, 2023
@stla @AhmedKhaled945
fix rstudio#1038: exact comparison of valueNew and value (rstudio#1039)
f10555a
AhmedKhaled945 pushed a commit to AhmedKhaled945/DT that referenced this pull request Jul 5, 2023
@stla @AhmedKhaled945
fix rstudio#1038: exact comparison of valueNew and value (rstudio#1039)
32648ca
AhmedKhaled945 pushed a commit to AhmedKhaled945/DT that referenced this pull request Oct 27, 2023
@stla @AhmedKhaled945
fix rstudio#1038: exact comparison of valueNew and value (rstudio#1039)
2063203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
R Markdown Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

edited numeric column and replace by empty cells instead of 0 by default
2 participants
@stla @yihui