Support Bootstrap 5 with datatable(style = "auto")
#1074
Conversation
R/datatables.R
Outdated
| # TODO: If DT adds support for BS > 5, update this logic | ||
| style = if (bs_v > 4) | ||
| "bootstrap5" | ||
| else if (bs_v > 3) | ||
| "bootstrap4" | ||
| else | ||
| "bootstrap" |
There was a problem hiding this comment.
| # TODO: If DT adds support for BS > 5, update this logic | |
| style = if (bs_v > 4) | |
| "bootstrap5" | |
| else if (bs_v > 3) | |
| "bootstrap4" | |
| else | |
| "bootstrap" | |
| style = paste0("bootstrap", if (bs_v > 3) bs_v) |
There was a problem hiding this comment.
I didn't do this because I'm not familiar with the process for updating the Bootstrap-specific styles in DT. I was imagining that if/when bslib begins offering Bootstrap 6, setting style = "bootstrap6" might be worse than using the "bootstrap5" styles, especially if Bootstrap 6 support in DT requires adding new CSS files to DT.
If a manual update is required, I'd personally leave this code (with all of its code smell) to avoid giving the false impression that Bootstrap 6 is automatically supported.
I defer to you though, since I haven't investigated how dependencies in DT are handled.
There was a problem hiding this comment.
Okay, that makes sense to me. Thank you!
|
|
Currently, when using a Bootstrap 5 theme from bslib and
style="auto",datatable()will use"bootstrap4"for the style. This results in a somewhat incorrectly styled datatable.This PR improves the logic to use latest DT-supported Bootstrap styles corresponding to the current bslib theme. In this formulation, future Bootstrap updates would require updating this logic (so I left a todo comment), but if there's an easy way to list the bootstrap versions suppported by DT I could update the PR so that this part doesn't need to be updated when future BS versions are added.