fix selection sync on client mode update (fixes #1125) #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yihui
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is "minimally invasive". After the reload of the table on the client and potentially restoring selections via JS callback function, the
cleanSelectedValues()function sends potentially incorrect<tbl>_xxx_selectedinformation to R. The patch uses the functions already implemented to send row/col/cell selections made via Select extension to R. It simply triggers one update right then and there. Since the messages get merged, this effectively overwrites the false message created by cleanSelectedValues() exactly when the bug #1125 is triggered. It may not be a complete fix for other scenarios, but it is brief and has minimal chance of breaking things for other use cases.