Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new extension: SearchBuilder #881

Merged
merged 2 commits into from Nov 20, 2020
Merged

Add the new extension: SearchBuilder #881

merged 2 commits into from Nov 20, 2020

Conversation

shrektan
Copy link
Collaborator

Closes #875

DT::datatable(
  iris, options = list(dom = "Qlfrtip"),
  extensions = "SearchBuilder"
)

image

@shrektan shrektan added this to the v0.17 milestone Nov 18, 2020
@shrektan shrektan changed the title Ext/search builder Add the new extension: SearchBuilder Nov 18, 2020
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thank you!

@yihui yihui merged commit 66b29f6 into master Nov 20, 2020
@yihui yihui deleted the ext/search-builder branch November 20, 2020 18:52
@philibe
Copy link

philibe commented Dec 1, 2020

Thank you for this implementation of SearchBuilder !

  • SearchBuilder works with your POC ...
  • ...but not with with my datas (server=TRUE) for "Greather Than" and similar.
  • It seems to work with my datas for "equals".

I will write an issue if necessary when I could.

My small test with my big datatable in production is with"rstudio/DT@806ca41".

@philibe
Copy link

philibe commented Dec 1, 2020

NEWS.md 0.17:

Note, as the time of writing, this extension only works on the client-side processing mode

soobing :)

@philibe
Copy link

philibe commented Jan 12, 2021

Before server side version of SearchBuilder, I installed jQuery QueryBuilder (without htmlwidgets) in my R shiny App.

@AhmedKhaled945
Copy link

is there any chance of this working on server = TRUE option?
Regards,

@yihui
Copy link
Member

yihui commented Nov 16, 2023

In theory, we could make this extension work with server = TRUE, but it's not a trivial amount of work. My estimate is that it will take about a week. It doesn't appear to be a difficult task (simple logical operations in R), but just requires time, which I always lack... If anyone wants to contribute, here is some guidance: https://yihui.org/en/2023/11/dt-searchbuilder/. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the 'searchBuilder' extension
4 participants