replace 'yihui/hugo-lithium-theme' with 'yihui/hugo-lithium' #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run `blogdown::new_site()` with the default `theme = "yihui/hugo-lithium-theme"`, I get an error: ``` Rendering content/post/2015-07-23-r-rmarkdown.Rmd Error: Unable to find theme Directory: /Users/rnolan/Dropbox/R/blog/themes/hugo-lithium-theme Serving the directory /Users/rnolan/Dropbox/R/blog at http://127.0.0.1:5641 To stop the server, run servr::daemon_stop("4326078320") or restart your R session Error in setwd(site.dir) : cannot change working directory ``` However I notice that even though there's no `/Users/rnolan/Dropbox/R/blog/themes/hugo-lithium-theme`, there is a `/Users/rnolan/Dropbox/R/blog/themes/hugo-lithium`. For reasons that I don't fully understand, when I run `blogdown::new_site(theme = "yihui/hugo-lithium-theme")`, everything works fine. This may be because https://github.com/yihui/hugo-lithium-theme redirects to https://github.com/yihui/hugo-lithium, but I don't know. In any case, https://github.com/yihui/hugo-lithium seems to be in working order and I think it should all work fine with that as the new default. Thanks Yihui and other authors and maintainers, your work makes our lives easier :)
|
Oops, hang on, some CI errors there that I think I can fix. Trying now. |
|
Ah. My bad. Thanks a lot for catching this issue! |
|
I see you are tweaking the Rd file. If you |
yihui
approved these changes
Apr 18, 2018
yihui
added a commit
that referenced
this pull request
Apr 18, 2018
…` according to `newdir` because that is the actual folder name this is a fundamental fix to #291
|
Hi @yihui, there are also a few places in the blogdown book where "hugo-lithium-theme" needs to be changed to "hugo-lithium". Would you also like a PR to fix these? |
|
@rorynolan Thanks! I have already changed them in the book in the commit 8ba2460 (I amended your PR). And the new version of blogdown is on CRAN now. |
|
OK great work. Thanks for everything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
blogdown::new_site()with the defaulttheme = "yihui/hugo-lithium-theme", I get an error:However I notice that even though there's no
/Users/rnolan/Dropbox/R/blog/themes/hugo-lithium-theme, there is a/Users/rnolan/Dropbox/R/blog/themes/hugo-lithium. For reasons that I don't fully understand, when I runblogdown::new_site(theme = "yihui/hugo-lithium"), everything works fine. This may be because https://github.com/yihui/hugo-lithium-theme redirects to https://github.com/yihui/hugo-lithium, but I don't know. In any case, https://github.com/yihui/hugo-lithium seems to be in working order and I think it should all work fine with that as the new default.Thanks Yihui and other authors and maintainers, your work makes our lives easier :)