-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete DESCRIPTION file #18
Comments
It is a hack to specify dependencies for Travis. Technically I can replace it with another way, but unfortunately I documented it in the bookdown book, which has been published last year: https://bookdown.org/yihui/bookdown/github.html If that is too much trouble for you, I'll just delete it and revise the documentation, even though I cannot change the hardcopies of the book. |
Sounds like we need to update the behavior in rsconnect, then. I'll see what we can do about that. Thanks. |
Moved to rstudio/rsconnect#192 |
FWIW the logic Packrat uses is here: https://github.com/rstudio/packrat/blob/master/R/dependencies.R#L474-L494 Can you set the |
@kevinushey That is a great idea! I'll do it. |
It looks like Travis failed, but perhaps for an unrelated reason? https://travis-ci.org/rstudio/bookdown-demo/builds/256202125?utm_source=github_status&utm_medium=notification |
Yeah I just fixed it. Specifying |
…fy the type in DESCRIPTION as Book) rstudio/bookdown-demo#18
Awesome! 😄 |
DESCRIPTION files currently confuse rsconnect and can make deploys not work properly. It looks like the DESCRIPTION file in this repo isn't actively being used; would it be safe to delete it?
(We're talking separately about changing rsconnect so that DESCRIPTION files don't break things.)
The text was updated successfully, but these errors were encountered: