Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete DESCRIPTION file #18

Closed
trestletech opened this issue Jul 21, 2017 · 8 comments
Closed

Delete DESCRIPTION file #18

trestletech opened this issue Jul 21, 2017 · 8 comments

Comments

@trestletech
Copy link

DESCRIPTION files currently confuse rsconnect and can make deploys not work properly. It looks like the DESCRIPTION file in this repo isn't actively being used; would it be safe to delete it?

(We're talking separately about changing rsconnect so that DESCRIPTION files don't break things.)

@yihui
Copy link
Member

yihui commented Jul 21, 2017

It is a hack to specify dependencies for Travis. Technically I can replace it with another way, but unfortunately I documented it in the bookdown book, which has been published last year: https://bookdown.org/yihui/bookdown/github.html

If that is too much trouble for you, I'll just delete it and revise the documentation, even though I cannot change the hardcopies of the book.

@trestletech
Copy link
Author

Sounds like we need to update the behavior in rsconnect, then. I'll see what we can do about that. Thanks.

@trestletech
Copy link
Author

Moved to rstudio/rsconnect#192

@kevinushey
Copy link

FWIW the logic Packrat uses is here:

https://github.com/rstudio/packrat/blob/master/R/dependencies.R#L474-L494

Can you set the Type: field in the DESCRIPTION file to something not equal to Package? Or does that break existing workflows?

@yihui
Copy link
Member

yihui commented Jul 21, 2017

@kevinushey That is a great idea! I'll do it.

@yihui yihui reopened this Jul 21, 2017
@yihui yihui closed this as completed in e4d98ba Jul 21, 2017
@kevinushey
Copy link

It looks like Travis failed, but perhaps for an unrelated reason? https://travis-ci.org/rstudio/bookdown-demo/builds/256202125?utm_source=github_status&utm_medium=notification

@yihui
Copy link
Member

yihui commented Jul 21, 2017

Yeah I just fixed it. Specifying Type: Book worked perfectly.

yihui added a commit to rstudio/bookdown that referenced this issue Jul 21, 2017
@kevinushey
Copy link

Awesome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants