Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"View Book Source" link always points to the "base" dir instead of "base + subdir" #1259

Open
kulbhushanchand opened this issue Sep 19, 2021 · 3 comments
Labels
bs4_book 🥾 help wanted ❤️ we'd love your help! next to consider for next release

Comments

@kulbhushanchand
Copy link

The "View Book Source" link at the bottom left corner always points to the base directory, which is fine if the docs source files resides in top level directory. However, if a subdirectory is defined for source files, it should (ideally) links to the "base+subdir".

Example of my setup :
top level directory: https://github.com/kulbhushanchand/BioNES
book_source directory: https://github.com/kulbhushanchand/BioNES/tree/master/docs_source
build directory: https://github.com/kulbhushanchand/BioNES/tree/master/docs

Setup:

bookdown::bs4_book:
  theme:
    primary: "#637238"
  repo: 
    base: https://github.com/kulbhushanchand/BioNES
    branch: master
    subdir: docs_source
  css: style.css

Link in question:
image

@cderv
Copy link
Collaborator

cderv commented Sep 20, 2021

@maelle you added the feature of subdir in #1036

It seems it was chosen to point book source to the main repo. However, it makes also sense to point to the subdir part of the repo when subdir is provided.

Do you agree ?

@maelle
Copy link
Contributor

maelle commented Sep 20, 2021

It might make sense indeed!

If not and in any case #1011 is about adding more flexibility incl. links for the left and right sidebars so users who disagree with whatever the default becomes could still get another behaviour.

@cderv cderv added the next to consider for next release label Sep 20, 2021
@kulbhushanchand
Copy link
Author

kulbhushanchand commented Apr 16, 2022

Any chance this issue request may make to the future release?

@cderv cderv added the help wanted ❤️ we'd love your help! label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bs4_book 🥾 help wanted ❤️ we'd love your help! next to consider for next release
Projects
Status: Backlog
Development

No branches or pull requests

3 participants