Skip to content

Commit

Permalink
Exit full-screen mode when a full-screen card is removed (#1005)
Browse files Browse the repository at this point in the history
* fix(card): Exit full-screen mode when a full-screen card is removed

* chore: yarn build

* refactor(card): Just observe `document.body` for removals

The card might be inside more dynamic UI, so we can't just observe from the parent node.

* fix: find nested matching elements

* chore: yarn build

* Resave distributed files (GitHub Action)

* Resave distributed files (GitHub Action)

* Resave data (GitHub Action)

* refactor: Use a Set instead of an array for `found` removed items

* chore: yarn build

* chore: try/catch `ShinyRemovedObserver` callback
  • Loading branch information
gadenbuie committed Mar 15, 2024
1 parent 7fe3a97 commit 43d46da
Show file tree
Hide file tree
Showing 7 changed files with 274 additions and 9 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@

* `page_navbar()` and `navset_bar()` now validate and transform `padding` and `gap` arguments into appropriate CSS values. (#991)

* Fixed an issue that could happen with a `card()` or `value_box()` that is rendered entirely via `renderUI()` when it is replaced by an updated card but the user had expanded the original card into full screen mode. Now the full screen state is reset for the new card or value box. If you want to update a card without potentially exiting the full-screen mode, update specific parts of the card using `uiOutput()` or `textOutput()`. (#1005)

# bslib 0.6.1

## Bug fixes
Expand Down
130 changes: 130 additions & 0 deletions inst/components/dist/components.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions inst/components/dist/components.js.map

Large diffs are not rendered by default.

Loading

0 comments on commit 43d46da

Please sign in to comment.