Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sliderInput() grid text should have higher contrast on some bootswatch dark mode themes #228

Closed
cpsievert opened this issue Jan 16, 2021 · 2 comments · Fixed by rstudio/shiny#3366
Closed

sliderInput() grid text should have higher contrast on some bootswatch dark mode themes #228

cpsievert opened this issue Jan 16, 2021 · 2 comments · Fixed by rstudio/shiny#3366
Labels
Bootswatch Issues with Bootswatch's source
Milestone
v0.2.5

Comments

@cpsievert
Copy link
Collaborator

For example this is darkly:

Screen Shot 2021-01-16 at 11 48 31 AM
@cpsievert cpsievert added this to the v0.2.5 milestone Jan 25, 2021
@cpsievert cpsievert added the Bootswatch Issues with Bootswatch's source label Jan 25, 2021
@cpsievert
Copy link
Collaborator Author

sliderInput() should probably use https://rstudio.github.io/bslib/articles/bs4-variables.html#input-plaintext-color instead of $input-color

@cpsievert cpsievert mentioned this issue Apr 12, 2021
Merged
2 tasks
cpsievert added a commit to rstudio/shiny that referenced this issue Apr 14, 2021
@cpsievert
Better color constrasting in sliderInput()
69fa3f0 
Closes rstudio/bslib#228
@cpsievert cpsievert mentioned this issue Apr 14, 2021
Merged
cpsievert added a commit to rstudio/shiny that referenced this issue Jun 14, 2021
@cpsievert
Better color constrasting in sliderInput()
9d149c1 
Closes rstudio/bslib#228
cpsievert added a commit to rstudio/shiny that referenced this issue Jun 14, 2021
@cpsievert
Better color constrasting in sliderInput() (#3366)
dc9c6ae 
* Better color constrasting in sliderInput()

Closes rstudio/bslib#228

* Update build script; recompile

* bslib tabsets now include data-bs-toggle
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bootswatch Issues with Bootswatch's source
Projects
None yet
Milestone
v0.2.5
Development

Successfully merging a pull request may close this issue.

Better color constrasting in sliderInput() rstudio/shiny
1 participant
@cpsievert